So, I have addressed the OS X builder issue. And the window builder,
which was using a different number than linux. Now all the builds use
the same information for there build id. Instead of each build
calculating a different number.
The version ID I have not changed. That comes from the properties
file. It is currently 4.2.x.
I think what you are asking is for the build _number_ to be
somewhere. I propose that the build ID take a new format:
<branch>@<last branch checkin> (<build number>)
So we have the number you want _and_ the number I want.
On 2008-07-31, at 16:00EDT, Mamye Kratt wrote:
If you want your build ID that is fine, but in addition to the
version ID which I need to identify the installer without having to
install. We were using the date on the OS X version because it broke
the last time we rebuilt the OS X builder and with release after
release I haven't had time to address it. :-(
Mamye
----- Original Message ----- From: "P T Withington" <[EMAIL PROTECTED]>
To: "Mamye Kratt" <[EMAIL PROTECTED]>
Cc: "Amy Muntz" <[EMAIL PROTECTED]>; "Laszlo-dev bug
reporting" <[email protected]>
Sent: Thursday, July 31, 2008 1:48 PM
Subject: Re: I know the windows and mac builds are failing...
Er, before my change, the 'build ID' was always the same as the
'version', so this is not a regression. How did you verify an
install before? You pointed out the 'build date' can be used to
uniquely identify a particular build.
I _really_ want the 'build ID' to identify the revision of the
source, without me having to guess or ask svn.
If you want the 'build ID' to also include the build name, I can
easily add that, now that all 3 platforms actually report the ID
as computed by the build script...
On 2008-07-31, at 15:33EDT, Mamye Kratt wrote:
Unfortunately, this makes confirming the installed version
impossible. If I download r10535 and it reports it is r10529,
that is confusing to the user. We also use the number on http://download.openlaszlo.org/nightly/trunk/10535
to make the tag. If no changes got checked in between 10529 and
10535 what is the harm? A quick 'svn diff -r 10529:10535' can
tell you that no changes were checked in.
Mamye
----- Original Message ----- From: "P T Withington" <[EMAIL PROTECTED]>
To: "Mamye Kratt" <[EMAIL PROTECTED]>
Cc: "Laszlo-dev bug reporting" <[email protected]>
Sent: Thursday, July 31, 2008 1:23 PM
Subject: Re: I know the windows and mac builds are failing...
On 2008-07-31, at 14:56EDT, Mamye Kratt wrote:
r10535, http://download.openlaszlo.org/nightly/trunk/10535, is
reporting 10529 on OS X, XP and Linux.
That is correct.
The 'build number' (the filename of the build on the build
machines and on the download page) is created by creating a tag
for the build, which increments the svn version number.
Actually, there must be 2 check-ins triggered by a build,
because each time you run a build, the build number increments
by 2.
But the 'build ID', the thing that I want to appear in the
versionInfoString, is computed by asking svn: "What is the last
change that was made in the branch that I am building?". And,
for trunk, as of this morning, that change is 10529. For the
'build ID' I concatenate the svn revision with the branch name;
from that you can determine the state of the source that was
used to create the build.
If you have multiple builds with no intervening checkins to the
branch being built, the 'build ID' will not change. (The tags
that the build system creates go in the tags branch, so do not
affect the being built branch.) Because it is true that the
build system itself may have changed between builds from
identical sources, we _might_ want to add something about that,
but for now, the 'build date' seems sufficient to distingush
different builds of the same source.
