On 2009-07-10, at 16:30EDT, Max Carlson wrote: > P T Withington wrote: >> So we cancel cancelling focus if we really mean for focus to focus? > > Yes, that seems to make the difference. > >> Remind me what the purpose of _cancelfocus is in the first place? > > They are used to avoid sending spurious onblur/onfocus events to the > LFC. This happens when a field is focused/blurred by Lz.focus - > which is who calls the sprite.gotFocus/Blur() from the LFC.
Where do the spurious events come from? I guess I don't get the "chain of command" here. It sounds like maybe you don't need _cancelfocus at all if you are going to turn it off every time you call gotFocus? What would be an example of when you _do_ want to cancel focus events? >> On 2009-07-10, at 15:27EDT, Max Carlson wrote: >>> Change 20090710-maxcarlson-4 by maxcarl...@bank on 2009-07-10 >>> 12:20:18 PDT >>> in /Users/maxcarlson/openlaszlo/trunk-clean >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Fix inputtext focusing issues in firefox >>> >>> Bugs Fixed: LPP-8284 - In dhtml it sometimes takes 2 clicks before >>> text can be entered >>> >>> Technical Reviewer: [email protected] >>> QA Reviewer: ptw >>> >>> Details: Clear out _cancelfocus and _cancelblur flags when the >>> sprite receives focus or blur events from the LFC. >>> >>> Tests: See LPP-8284 >>> >>> Files: >>> M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/20090710-maxcarlson-4.tar > > -- > Regards, > Max Carlson > OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
