Perhaps the text in the testcase should be clearer. I was just able to reproduce the bug (it's Firefox only) on trunk at r14329 on OS X and Windows. I ran lpp-8284.lzx?lzr=dhtml&debug=true (downloaded from the file attachments section of http://jira.openlaszlo.org/jira/browse/LPP-8284). The important thing is to only click once in the red field after clicking 'show form' the second time. After a single click, I can't type into the field even though the cursor shows up. My change fixes this.
Good catch on the other issue. Can you file a bug for this, or shall I? Thanks! André Bargull wrote: > I cannot reproduce the bug you describe in your testcase (tr...@14342 - > DHTML debug-mode in Firefox, Opera, Safari). > > There is one issue, though: > If you click on "show form" the first time, the yellow inputtext is > focused properly. Now click on "ok" and then again on "show form": the > yellow inputtext is not focused. This works as expected in swf. > Applying your changeset does not fix this broken behaviour. > (Reproducible with Firefox, Opera, Safari.) > > > On 7/18/2009 3:38 AM, Max Carlson wrote: >> André or Tucker, can I get a review of this one? Thanks! >> >> Max Carlson wrote: >>> Change 20090710-maxcarlson-4 by maxcarl...@bank on 2009-07-10 >>> 12:20:18 PDT >>> in /Users/maxcarlson/openlaszlo/trunk-clean >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Fix inputtext focusing issues in firefox >>> >>> Bugs Fixed: LPP-8284 - In dhtml it sometimes takes 2 clicks before >>> text can be entered >>> >>> Technical Reviewer: [email protected] >>> QA Reviewer: ptw >>> >>> Details: Clear out _cancelfocus and _cancelblur flags when the sprite >>> receives focus or blur events from the LFC. >>> >>> Tests: See LPP-8284 >>> >>> Files: >>> M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/20090710-maxcarlson-4.tar >> -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
