OK, I have gotten all of these.  I will look into handling block
comments as blocks.  Right now it only honors them as line when
overlaying the highlight.

On Sun, Nov 9, 2014 at 2:12 AM, Christophe Rhodes <[email protected]> wrote:
> Craig Earls <[email protected]> writes:
>
>> I think I have figured out what is going on here.  I pushed a fix to
>> the entity boundary detection code and fixes all of Christoper's issue
>> with his example file.
>
> Thank you!  Things are certainly much, much better.  I still see some
> more minor problems, which it might be possible to address while the
> details are still fresh?  With the attached file:
>
> * everything is statically fontified correctly, but the
>   current-transaction/directive overlay is odd.  As I move down the
>   file, line by line (with C-n) the overlay is initially applied
>   line-by-line, but after moving off line 7 the overlay stays where it
>   is until point is on line 15, at which point line 14 is highlighted.
>   Similarly it then stays there until point is on line 21, where line 20
>   is highlighted.  (If I had to guess, I would point the finger at the
>   fact that those comment lines have embedded dates).
>
> * similarly, when point is anywhere on the first directive line (line
>   30), the current-transaction/directive overlay highlights line 27.
>   Once point is anywhere on line 31, line 30 is highlighted.  I don't
>   really understand what's going on here.
>
> * with point on line 33 or 34, the overlay correctly highlights the
>   first transaction.  When point moves to line 35, only the two postings
>   in the transaction are highlighted.  Similarly, with point on lines
>   37-40, the second transaction is highlighted in full, but on line 41
>   only line 40 is highlighted.  I would guess that the amusing account
>   number, which could possibly be construed as a date, is confusing the
>   transaction parser.
>
> * finally, at least for this batch, M-n is bound to a useful command,
>   `ledger-navigate-next-xact-or-directive'; it might be nice for it to
>   treat comment blocks differently, but I can live with what it does.
>   M-p is bound to `ledger-navigate-prev-xact', which is not a command,
>   and also seems asymmetrical in behaviour (I can't navigate back using
>   M-p what I have navigated forward throgh M-n).
>
>
>
> Again, thank you for the fixes.
>
> Best wishes,
>
> Christophe
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups 
> "Ledger" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Craig, Corona De Tucson, AZ
enderw88.wordpress.com

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"Ledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to