... And I will try not to forget the actual patch the next times round.

http://atlas.natulte.net/~dave/aic_doc.patch

- Dave

On 1/10/07, David Anderson <[EMAIL PROTECTED]> wrote:
> Hi,
>
> So, now that the code is reindented, here is the first documentation patch.
>
> On a side-note, I have a couple of questions regarding the code of the
> AIC driver.
>
> The mode passed to aic_set_vector is defined as an U32, with possible
> values #define'd. Is there a reason the API does not use an enum (and
> then cast it to U32 when setting the register, obviously) ? Same
> question for the isr parameter: any reason to make the caller cast the
> value, rather than accept a void(*)(void) and cast it to U32 in the
> function?
>
> - Dave
>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Lejos-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lejos-discussion

Reply via email to