On 1/10/07, Charles Manning <[EMAIL PROTECTED]> wrote: > I have two very minor suggestions: > 1) Title of "NXT's Advanced Interrupt Controller" I think should rether read > "AT91SAM7's Advanced Interrupt Controller". This code will likely be used on > non-NXT SAM7-based devices and I think saying NXT makes it sound like this > code is NXT specific.
Good point. Description changed, as well as a few other references to the nxt throughout the comments. > 2) Use of term "garbage collection". This term has many special meanings, > particularly its meaning in Java. I design flash file systems too (with > garbage collection) so it hits two nerves with me. I think a better term > would be "clean up". I have this tendency to use complicated and confusing terms where simpler ones would do. Fixed. > How should we progress with these patches? > Who should apply them and do the checkins to svn? Well, if you folks give me svn access, I can commit them myself, or I can keep posting them for review and have you or someone else submit them. Having direct svn access would let me work faster though. - Dave ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Lejos-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lejos-discussion
