On Wednesday 10 January 2007 21:57, David Anderson wrote: > ... And I will try not to forget the actual patch the next times round. > > http://atlas.natulte.net/~dave/aic_doc.patch
Dave Thanks for that effort. I have two very minor suggestions: 1) Title of "NXT's Advanced Interrupt Controller" I think should rether read "AT91SAM7's Advanced Interrupt Controller". This code will likely be used on non-NXT SAM7-based devices and I think saying NXT makes it sound like this code is NXT specific. 2) Use of term "garbage collection". This term has many special meanings, particularly its meaning in Java. I design flash file systems too (with garbage collection) so it hits two nerves with me. I think a better term would be "clean up". How should we progress with these patches? Who should apply them and do the checkins to svn? -- Charles > > - Dave > > On 1/10/07, David Anderson <[EMAIL PROTECTED]> wrote: > > Hi, > > > > So, now that the code is reindented, here is the first documentation > > patch. > > > > On a side-note, I have a couple of questions regarding the code of the > > AIC driver. > > > > The mode passed to aic_set_vector is defined as an U32, with possible > > values #define'd. Is there a reason the API does not use an enum (and > > then cast it to U32 when setting the register, obviously) ? Same > > question for the isr parameter: any reason to make the caller cast the > > value, rather than accept a void(*)(void) and cast it to U32 in the > > function? > > > > - Dave > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share > your opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Lejos-discussion mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/lejos-discussion ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Lejos-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lejos-discussion
