On Fri, Jul 10, 2009 at 5:27 PM, TL<[email protected]> wrote: > Are you sure that Edward knows that the open_with feature will be > broken in rc1? The last postings on Wednesday were:
mod_tempfname,py is the one that's broken, not open_with.py. >>> The following change works: >>> Line 893: subprocess.Popen(vtuple, shell=False) > ... >>> I suggest you make the needed change to leoCommands.py >>> and check it in. > >> Yes, I'll do that this evening. You must be misunderstanding me. No way are we going to make shell=False the default. We can special case that for vim.py, for Windows. Or when there are spaces in filenames. I've understood that since I changed to shell=True, it hasn't worked on any occasion for you. Therefore, it doesn't make sense to leave a halfway fix in. The cycle of fixing & testing this has been so lengthy that there just was no time to get a proper fix for spaces-in-filenames before rc1. Right now, the workaround is not to use mod_tempfname.py. -- Ville M. Vainio http://tinyurl.com/vainio --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~----------~----~----~----~------~----~------~--~---
