On 2/3/2014 10:03 AM, Edward K. Ream wrote:
On Mon, Feb 3, 2014 at 8:56 AM, Edward K. Ream <[email protected] <mailto:[email protected]>> wrote:

​> [p.script] is on the list to do today.  It's just a few lines of code.​

Done at rev 6636.  Here it is::


​    def __get_script(self):
        p = self
        return g.getScript(p.v.context,p,
            useSelectedText=False,# Always return the entire expansion.
            forcePythonSentinels=True,
            useSentinels=True)

    script = property(
        __get_script, # __set_script,
        doc = "position script property")​

As you can see, I have chosen to include all of p.b in the expansion and to include sentinels. Setting useSelectedText=False seems like the only correct choice, but including sentinels is slightly debatable. Any comments?

Edward
--
I would argue against sentinels, simply because not all users are going to be using this for python scripts -- for example, you could use this to get a complex text document that you have broken into pieces -- one where you would certainly *not* want sentinels.

I'd say p.script should have no sentinels, and p.script_with_sentinels (or similar) could have python sentinels. Just my thoughts.

-->Jake

--
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to