On Wed, Mar 7, 2018 at 11:14 PM, Terry Brown <[email protected]> wrote:
> g.log is a completely separate function. It should not be changed.
>
> Yes it's completely separate. It appears to
>
> be used exactly zero times in the code base
> ...
>
> You could say that "hello
>
> world" in "Leo" is:
g.es("Hello world")
>
> Wouldn't
>
> g.log("Hello world")
>
> be so much easier to remember?
>
Ok, I'll make g.log a synonym for g.es, and rename the existing g.log to
something else.
M
> y point was that writing color="warning" is clearly an
>
> incomplete migration from legacy code
...
> Admittedly as an implementation detail of warning() it matters less,
>
> but I think you're saying that's also what you'd write if you wanted a
>
> warning colored g.es() call.
>
See below re #793.
>
> Until recent changes, these settings worked:
>
> @color log_text_foreground_color = #93a1a1
> @color log_text_background_color = #073642
> @color log_error_color = #dc322f
> @color log_warning_color = #268bd2
>
I have just reopened #788
<https://github.com/leo-editor/leo-editor/issues/788> to handle this.
In e4e0b81ad91e
>
> g.error('error')
> g.warning('warning')
>
> and
>
> g.blue('blue')
> g.red('red')
>
> give different results
That depends on the theme and defaults in leoSettings.leo. I'll add
defaults to leoSettings.leo so legacy operation is restored.
To me this just seems like the ideal time to clean things u
> p
> ...
> let's rename everything by
>
> role instead of by color.
>
>
>
I kinda agree, but this is a non-trivial project. I have just created
#793: Color messages by role.
<https://github.com/leo-editor/leo-editor/issues/793> This is scheduled for
5.7.1, but I'm not sure it is worth the effort.
BTW, I plan to migrate all the legacy themes in leo/themes/old_themes.leo
to be separate .leo files in leo/themes. This will be a straightforward
once the Themes menu becomes functional, which I expect to happen today.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
