On Mon, Mar 28, 2011 at 02:06:59AM +0400, Anatoly Nenashev wrote:
> On 28.03.2011 01:04, Diego Biurrun wrote:
>> On Sun, Mar 27, 2011 at 10:16:26PM +0200, Anton Khirnov wrote:
>>    
>>> From: anatoly<[email protected]>
>>>
>>> ---
>>>   libavcodec/Makefile    |    1 +
>>>   libavcodec/allcodecs.c |    1 +
>>>   libavcodec/mxpegdec.c  |  331 
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>   3 files changed, 333 insertions(+), 0 deletions(-)
>>>   create mode 100644 libavcodec/mxpegdec.c
>>>      
>> This is missing changelog and docs update, as well as a minor version
>> bump.  Which confuses me, since the first patch in the thread has
>> those changes...
>>    
> I've updated changelog and docs but don't know how to do a minor version  
> bump.

Increase LIBAVCODEC_VERSION_MINOR in libavcodec/version.h.

> Also I this that this change must be done by commiter because review  
> process can be finished after a couple of days, weeks or years.

Nah, you should do it; it's easier for the committer to change your
patch then and there are no other decoders in the queue right now,
so there should not be conflicts.

More comments below, but wait for further review and/or a day before
sending an updated patch.

> --- a/Changelog
> +++ b/Changelog
> @@ -60,6 +60,7 @@ version <next>:
>  - rename aspect filter to setdar, and pixelaspect to setsar
>  - IEC 61937 demuxer
>  - Mobotix .mxg demuxer
> +- Mobotix MxPEG decoder
>  - frei0r source added
>  - hqdn3d filter added
>  - RTP depacketization of QCELP

Please add the entry to the end of the list, they are ordered
chronologically.

> --- /dev/null
> +++ b/libavcodec/mxpegdec.c
> @@ -0,0 +1,342 @@
> +/*
> + * MxPEG decoder
> + * Copyright (c) 2011 Anatoly Nenashev
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or

This is libav, not FFmpeg, so please use the correct license header.

> --- /dev/null
> +++ b/libavcodec/mxpegdec.h
> @@ -0,0 +1,39 @@
> +/*
> + * MxPEG decoder header
> + * Copyright (c) 2011 Anatoly Nenashev
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or

ditto

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to