Hi, On Mon, Mar 28, 2011 at 9:09 AM, Anatoly Nenashev <[email protected]> wrote: > On 28.03.2011 02:58, Diego Biurrun wrote: >> >> [...] >> Nah, you should do it; it's easier for the committer to change your >> patch then and there are no other decoders in the queue right now, >> so there should not be conflicts. >> >> More comments below, but wait for further review and/or a day before >> sending an updated patch. >> [...] > > Updated version of patch with minor version bump and license header changes. [..] > +int ff_mxpeg_decode_frame(AVCodecContext *avctx, > + void *data, int *data_size, > + AVPacket *avpkt) [..] > + case EOI: > + goto the_end; > + break;
the break seems pointless. More seriously, I've done a good review of this part in earlier versions, it looks good to me. I wish I had time to look closer at the performance effects it has on regular JPEG decoding, but I unfortunately don't have time right now, so all patches are fine and can be committed with the above line of code changed by the committer. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
