Diego Biurrun <[email protected]> writes:

> ---
>  libavcodec/Makefile       |   10 +++-------
>  libavcodec/cos_tablegen.c |    2 +-
>  2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index 1063936..4a0ed2a 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -676,14 +676,10 @@ include $(SUBDIR)../subdir.mak
>  
>  $(SUBDIR)dct-test$(EXESUF): $(SUBDIR)dctref.o
>  
> -$(SUBDIR)cos_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> -     $(M)./$< > $@
> -
> -$(SUBDIR)cos_fixed_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> -     $(M)./$< cos fixed > $@
> +$(SUBDIR)%_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> +     $(M)./$< $* > $@
>  
> -$(SUBDIR)sin_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> -     $(M)./$< sin > $@
> +.SECONDARY: $(SUBDIR)cos_tables.c $(SUBDIR)cos_fixed_tables.c 
> $(SUBDIR)sin_tables.c

Using .SECONDARY is fragile and almost always wrong.  In fact, I have
never yet seen a case where using it did the right thing.  Thus I am
highly sceptical to this patch.

DO NOT APPLY THIS.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to