Diego Biurrun <[email protected]> writes:

> ---
>  libavcodec/Makefile       |   10 +++-------
>  libavcodec/cos_tablegen.c |    2 +-
>  2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index 1063936..4a0ed2a 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -676,14 +676,10 @@ include $(SUBDIR)../subdir.mak
>  
>  $(SUBDIR)dct-test$(EXESUF): $(SUBDIR)dctref.o
>  
> -$(SUBDIR)cos_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> -     $(M)./$< > $@
> -
> -$(SUBDIR)cos_fixed_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> -     $(M)./$< cos fixed > $@
> +$(SUBDIR)%_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> +     $(M)./$< $* > $@
>  
> -$(SUBDIR)sin_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF)
> -     $(M)./$< sin > $@
> +.SECONDARY: $(SUBDIR)cos_tables.c $(SUBDIR)cos_fixed_tables.c 
> $(SUBDIR)sin_tables.c
>  
>  ifdef CONFIG_SMALL
>  $(SUBDIR)%_tablegen$(HOSTEXESUF): HOSTCFLAGS += -DCONFIG_SMALL=1
> diff --git a/libavcodec/cos_tablegen.c b/libavcodec/cos_tablegen.c
> index 6bfb8ea..3df64d3 100644
> --- a/libavcodec/cos_tablegen.c
> +++ b/libavcodec/cos_tablegen.c
> @@ -51,7 +51,7 @@ int main(int argc, char *argv[])
>  {
>      int i, j;
>      int do_sin = argc > 1 && !strcmp(argv[1], "sin");
> -    int fixed  = argc > 2 && !strcmp(argv[2], "fixed");
> +    int fixed  = argc > 1 && !strcmp(argv[1], "cos_fixed");
>      double (*func)(double) = do_sin ? sin : cos;

In addition to what I already said, this makes it harder to add
fixed-point sine tables, which we will want at some point.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to