Diego Biurrun <[email protected]> writes: > On Thu, May 19, 2011 at 05:39:00PM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > --- a/libavcodec/Makefile >> > +++ b/libavcodec/Makefile >> > @@ -676,14 +676,10 @@ include $(SUBDIR)../subdir.mak >> > >> > -$(SUBDIR)cos_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF) >> > - $(M)./$< > $@ >> > - >> > -$(SUBDIR)cos_fixed_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF) >> > - $(M)./$< cos fixed > $@ >> > +$(SUBDIR)%_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF) >> > + $(M)./$< $* > $@ >> > >> > -$(SUBDIR)sin_tables.c: $(SUBDIR)cos_tablegen$(HOSTEXESUF) >> > - $(M)./$< sin > $@ >> > +.SECONDARY: $(SUBDIR)cos_tables.c $(SUBDIR)cos_fixed_tables.c >> > $(SUBDIR)sin_tables.c >> >> Using .SECONDARY is fragile and almost always wrong. In fact, I have >> never yet seen a case where using it did the right thing. Thus I am >> highly sceptical to this patch. > > It has always worked fine for me
But you don't know why. Never do things you do not understand why they appear to work. > - what do you suggest instead .PRECIOUS? That one has the same issues. I've never managed to get it behaving consistently. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
