On 05/24/2011 01:35 PM, Stefano Sabatini wrote: > On date Tuesday 2011-05-24 11:50:05 +0200, Stefano Sabatini encoded: >> On date Tuesday 2011-05-24 07:34:57 +0200, Anton Khirnov encoded: >>> Hi, >>> with demuxer private options in my local tree, it's time to start >>> replacing AVFormatParameters with private options. >>> Note that i can't test the bktr/sndio/oss/v4l patches, so it'd be nice if >>> somebody else did. You can get this tree from >>> git://git.khirnov.net/git/libav >>> branch ap. >> >> Overall, very nice work, I had wanted to do that for ages (but I >> wanted to clean-up options a bit before). >> > >> I looked at the patches, and they look OK to me, but I'll try to have >> a deeper look into them. > > I read them all, they look fine but for the strcase/strcasecmp > consideration, and the .class_name nitpick (in libavcodec it is set to > the corresponding codec .name rather than .long_name).
I think the class_name should be closer to the long_name in most cases. It should also include the type of element it is (demuxer/muxer/encoder/decoder/etc...). After all, it is what gets printed in the commandline help text. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
