On Sun, Jul 31, 2011 at 00:46, Diego Biurrun <[email protected]> wrote: > On Sun, Jul 31, 2011 at 12:27:46AM +0800, Yu-Jie Lin wrote: >> +0.0 is display.screen number of your X11 server, same as the DISPLAY >> environment > > is the > >> +0.0 is display.screen number of your X11 server, same as the DISPLAY >> environment > > is the > >> +If @var{show_region} AVOption is specified with @var{1} as value, then the >> +grabbing region will be indicated on screen. With this option, it's easy to >> +know what is being grabbed if only grab a portion of the screen. > > know what is being grabbed if only a portion of the screen is grabbed. >
Thanks for correcting my English. >> --- a/libavdevice/x11grab.c >> +++ b/libavdevice/x11grab.c >> @@ -72,9 +73,74 @@ struct x11_grab >> >> + screen = DefaultScreen(dpy); >> + attribs.override_redirect = True; >> + s->region_win = XCreateWindow( >> + dpy, RootWindow(dpy, screen), >> + s->x_off - REGION_WIN_BORDER, > > ugly linebreak > >> + rect.width = s->width; >> + rect.height = s->height; > > nit: align '=' I sort of brought another language's coding style into C. Old habit is hard to change, I need to keep reminding myself. ;) Will update my patch later. By the way, what does "nit" mean? _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
