Example commands:

    ./ffmpeg -f x11grab -s cif -r 25 -i :0.0+10,20;showregion /tmp/out.mpg
    ./ffmpeg -f x11grab -s cif -r 25 -i ':0.0;followmouse;showregion'
/tmp/out.mpg

First one would draw a box around the grabbing region, second one, the
box will follow the mouse.

I use dashed lines because pure white or black lines sometimes are
hard to see, especially with webpages, which mostly with white
background.

Yu-Jie Lin
From a5e014ba768302395082251ee1cb947a0b61310e Mon Sep 17 00:00:00 2001
From: Yu-Jie Lin <[email protected]>
Date: Sat, 30 Jul 2011 19:13:43 +0800
Subject: [PATCH 2/2] x11grab: add showregion option.

Draw the current grabbing region for indication..

Signed-off-by: Yu-Jie Lin <[email protected]>
---
 doc/ffmpeg.texi       |   17 ++++++++
 doc/indevs.texi       |   14 ++++++-
 libavdevice/x11grab.c |  102 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 132 insertions(+), 1 deletions(-)

diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index 9b3728b..f3a25eb 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -919,6 +919,23 @@ ffmpeg -f x11grab -s cif -r 25 -i ':0.0;followmouse=100' /tmp/out.mpg
 variable. Grabbing region follows the mouse pointer, but only when mouse
 pointer reaches within 100 pixels to the edge of grabbing region.
 
+@example
+ffmpeg -f x11grab -s cif -r 25 -i :0.0+10,20;showregion /tmp/out.mpg
+@end example
+
+0.0 is display.screen number of your X11 server, same as the DISPLAY environment
+variable. 10 is the x-offset and 20 the y-offset for the grabbing, also a
+grabbing region will be indicated on screen.
+
+@example
+ffmpeg -f x11grab -s cif -r 25 -i ':0.0;followmouse;showregion' /tmp/out.mpg
+@end example
+
+0.0 is display.screen number of your X11 server, same as the DISPLAY environment
+variable. Grabbing region follows the mouse pointer and a grabbing region
+will be indicated on screen.
+
+
 @section Video and Audio file format conversion
 
 Any supported file format and protocol can serve as input to ffmpeg:
diff --git a/doc/indevs.texi b/doc/indevs.texi
index 3876807..269f546 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -227,7 +227,7 @@ This device allows to capture a region of an X11 display.
 The filename passed as input has the syntax:
 @example
 [@var{hostname}]:@var{display_number}.@var{screen_number}[+@var{x_offset},@var{y_offset}]
-[;followmouse[=@var{follow_mouse}]]
+[;followmouse[=@var{follow_mouse}]][;showregion]
 @end example
 
 @var{hostname}:@var{display_number}.@var{screen_number} specifies the
@@ -265,4 +265,16 @@ ffmpeg -f x11grab -r 25 -s cif -i ':0.0;followmouse' out.mpg
 ffmpeg -f x11grab -r 25 -s cif -i ':0.0;followmouse=100' out.mpg
 @end example
 
+If "showregion" is specified, then the grabbing region will be indicated on
+screen. With this option, it's easy to know what is being grabbed if only grab
+a portion of the screen.
+
+For example:
+@example
+ffmpeg -f x11grab -r 25 -s cif -i ':0.0+10,20;showregion' out.mpg
+
+# With followmouse
+ffmpeg -f x11grab -r 25 -s cif -i ':0.0;followmouse;showregion' out.mpg
+@end example
+
 @c man end INPUT DEVICES
diff --git a/libavdevice/x11grab.c b/libavdevice/x11grab.c
index c04c198..326acf7 100644
--- a/libavdevice/x11grab.c
+++ b/libavdevice/x11grab.c
@@ -47,6 +47,7 @@
 #include <X11/Xproto.h>
 #include <X11/Xutil.h>
 #include <sys/shm.h>
+#include <X11/extensions/shape.h>
 #include <X11/extensions/XShm.h>
 #include <X11/extensions/Xfixes.h>
 
@@ -72,9 +73,73 @@ struct x11_grab
     XShmSegmentInfo shminfo; /**< When using XShm, keeps track of XShm infos */
     int  draw_mouse;         /**< Set by a private option. */
     int follow_mouse;        /**< Set by a private option. */
+    int show_region;         /**< set by a private option. */
+    Window region_win;       /**< set by a private option. */
     char *framerate;         /**< Set by a private option. */
 };
 
+#define REGION_WIN_BORDER 3
+/**
+ * Draw grabbing region window
+ *
+ * @param s x11_grab context
+ */
+static void
+x11grab_draw_region_win(struct x11_grab *s)
+{
+    Display *dpy = s->dpy;
+    int screen;
+    Window win = s->region_win;
+    GC gc;
+
+    screen = DefaultScreen(dpy);
+    gc = XCreateGC(dpy, win, 0, 0);
+    XSetForeground(dpy, gc, WhitePixel(dpy, screen));
+    XSetBackground(dpy, gc, BlackPixel(dpy, screen));
+    XSetLineAttributes(dpy, gc, 3, LineDoubleDash, 0, 0);
+    XDrawRectangle(dpy, win, gc,
+                   1, 1,
+                   s->width + REGION_WIN_BORDER * 2 - 1 * 2 - 1,
+                   s->height + REGION_WIN_BORDER * 2 - 1 * 2 - 1);
+    XFreeGC(dpy, gc);
+}
+
+/**
+ * Initialize grabbing region window
+ *
+ * @param s x11_grab context
+ */
+static void
+x11grab_region_win_init(struct x11_grab *s)
+{
+    Display *dpy = s->dpy;
+    int screen;
+    XSetWindowAttributes attribs;
+    XRectangle rect;
+
+    screen = DefaultScreen(dpy);
+    attribs.override_redirect = True;
+    s->region_win = XCreateWindow(
+        dpy, RootWindow(dpy, screen),
+        s->x_off - REGION_WIN_BORDER,
+        s->y_off - REGION_WIN_BORDER,
+        s->width + REGION_WIN_BORDER * 2,
+        s->height + REGION_WIN_BORDER * 2,
+        0, CopyFromParent,
+        InputOutput, CopyFromParent,
+        CWOverrideRedirect, &attribs);
+    rect.x = 0;
+    rect.y = 0;
+    rect.width = s->width;
+    rect.height = s->height;
+    XShapeCombineRectangles(dpy, s->region_win,
+                            ShapeBounding, REGION_WIN_BORDER, REGION_WIN_BORDER,
+                            &rect, 1, ShapeSubtract, 0);
+    XMapWindow(dpy, s->region_win);
+    XSelectInput(dpy, s->region_win, ExposureMask | StructureNotifyMask);
+    x11grab_draw_region_win(s);
+}
+
 /**
  * Initialize the x11 grab device demuxer (public device demuxer API).
  *
@@ -115,6 +180,8 @@ x11grab_read_header(AVFormatContext *s1, AVFormatParameters *ap)
         x11grab->follow_mouse = -1;
         sscanf(offset, ";followmouse=%d", &x11grab->follow_mouse);
     }
+    x11grab->region_win = 0;
+    x11grab->show_region = !!strstr(param, ";showregion");
     /* trim dpyname to only [hostname]:<display_number>.<screen_number> */
     if (offset = strpbrk(param, "+;"))
         *offset = 0;
@@ -165,6 +232,19 @@ x11grab_read_header(AVFormatContext *s1, AVFormatParameters *ap)
         av_log(s1, AV_LOG_INFO, "followmouse is enabled, resetting grabbing region to x: %d y: %d\n", x_off, y_off);
     }
 
+    screen = DefaultScreen(dpy);
+    screen_w = DisplayWidth(dpy, screen);
+    screen_h = DisplayHeight(dpy, screen);
+
+    if (x11grab->follow_mouse) {
+        XQueryPointer(dpy, RootWindow(dpy, screen), &w, &w, &x_off, &y_off, &ret, &ret, &ret);
+        x_off -= x11grab->width >> 1;
+        y_off -= x11grab->height >> 1;
+        x_off = FFMIN(FFMAX(x_off, 0), screen_w - x11grab->width);
+        y_off = FFMIN(FFMAX(y_off, 0), screen_h - x11grab->height);
+        av_log(s1, AV_LOG_INFO, "followmouse is enabled, resetting grabbing region to x: %d y: %d\n", x_off, y_off);
+    }
+
     use_shm = XShmQueryExtension(dpy);
     av_log(s1, AV_LOG_INFO, "shared memory extension %s found\n", use_shm ? "" : "not");
 
@@ -404,6 +484,7 @@ x11grab_read_packet(AVFormatContext *s1, AVPacket *pkt)
     int screen_h;
     int x, y, _;
     int follow_mouse = s->follow_mouse;
+    XEvent evt;
 
     int64_t curtime, delay;
     struct timespec ts;
@@ -458,6 +539,22 @@ x11grab_read_packet(AVFormatContext *s1, AVPacket *pkt)
         // adjust grabbing region position if it goes out of screen.
         s->x_off = x_off = FFMIN(FFMAX(x_off, 0), screen_w - s->width);
         s->y_off = y_off = FFMIN(FFMAX(y_off, 0), screen_h - s->height);
+
+        if (s->show_region && s->region_win)
+            XMoveWindow(dpy, s->region_win,
+                        s->x_off - REGION_WIN_BORDER,
+                        s->y_off - REGION_WIN_BORDER);
+    }
+
+    if (s->show_region) {
+        if (s->region_win) {
+            // clean up the events, and do the initinal draw or redraw.
+            for (evt.type = NoEventMask; XCheckMaskEvent(dpy, ExposureMask | StructureNotifyMask, &evt); );
+            if (evt.type)
+                x11grab_draw_region_win(s);
+        } else {
+            x11grab_region_win_init(s);
+        }
     }
 
     if(s->use_shm) {
@@ -501,6 +598,10 @@ x11grab_read_close(AVFormatContext *s1)
         x11grab->image = NULL;
     }
 
+    if (x11grab->region_win) {
+        XDestroyWindow(x11grab->dpy, x11grab->region_win);
+    }
+
     /* Free X11 display */
     XCloseDisplay(x11grab->dpy);
     return 0;
@@ -513,6 +614,7 @@ static const AVOption options[] = {
     { "framerate", "", OFFSET(framerate), FF_OPT_TYPE_STRING, {.str = "ntsc"}, 0, 0, DEC },
     { "draw_mouse", "Draw the mouse pointer.", OFFSET(draw_mouse), FF_OPT_TYPE_INT, { 1 }, 0, 1, DEC },
     { "follow_mouse", "Follow the mouse pointer.", OFFSET(follow_mouse), FF_OPT_TYPE_INT, { 0 }, -1, INT_MAX, DEC },
+    { "show_region", "Show the grabbing region.", OFFSET(show_region), FF_OPT_TYPE_INT, { 0 }, 0, 1, DEC },
     { NULL },
 };
 
-- 
1.7.3.4

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to