On Sun, Jul 31, 2011 at 01:19, Anton Khirnov <[email protected]> wrote:
>
> On Sat, 30 Jul 2011 18:45:22 +0200, Luca Barbato <[email protected]> wrote:
>> On 7/30/11 6:27 PM, Yu-Jie Lin wrote:
>> > + { "show_region", "Show the grabbing region.", OFFSET(show_region),
>> > FF_OPT_TYPE_INT, { 0 }, 0, 1, DEC },
>>
>> Using the boolean type seems better, or do you plan to use different values?
>
> There is no bool type in avoptions.
So, I guess the constant in avoptions is the best way?
"-show_region 1" actually looks weird if considering from the
perspective of a normal user.
However, I still want to keep it as "1" or at least some common
understandable name in libav (which I don't know if any other already
have) like
"-show_region on" or "-show_region enable"
, or maybe
"-show_region dashed"
since it is drawn with dashed lines and possibly can add more styles
later like "white_sandwich_black" (my previous style before I
submitted the first patch to libav) or "double_rainbow" (just
kidding), if someone complains that visualization of dashed line is
too strong or too ugly.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
