On Thu, 13 Oct 2011, Luca Barbato wrote:

On 10/13/11 1:20 PM, Martin Storsjö wrote:
+ { "rtsp_transport", "RTSP transport protocols", OFFSET(lower_transport_mask), AV_OPT_TYPE_FLAGS, {0}, 0, INT_MAX, DEC|ENC, "rtsp_transport" }, \ + { "udp", "UDP", 0, AV_OPT_TYPE_CONST, {1<< RTSP_LOWER_TRANSPORT_UDP}, 0, 0, DEC|ENC, "rtsp_transport" }, \ + { "tcp", "TCP", 0, AV_OPT_TYPE_CONST, {1<< RTSP_LOWER_TRANSPORT_TCP}, 0, 0, DEC|ENC, "rtsp_transport" }, \ + { "udp_multicast", "UDP multicast", 0, AV_OPT_TYPE_CONST, {1<< RTSP_LOWER_TRANSPORT_UDP_MULTICAST}, 0, 0, DEC, "rtsp_transport" },

I'd use the proto+proto:// syntax.

That forces us to still keep on modifying the url and strip out that, since the normal plain rtsp:// url still needs to be included within the requests.

Also it's worse if you're e.g. building a player app, where the rtsp url is given as user input (or as input from urls received externally or whatever), where the app would have to edit the urls to include this if the app deems it necessary, compared to setting these options out of band from the actual url.

Moving the options from one place in the url to another isn't really progress IMO.

Additionally, that still has the issue of parsing options from URLs and redirects - if I give the input url rtsp+tcp://foo/bar, which redirects me to rtsp://other/server, I'll reparse that url, forgetting about the options passed in the previous one. Sure that can be fixed by even more kludges, but that's all what I'm trying to get rid of here.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to