On Mon, 17 Oct 2011, Anton Khirnov wrote:


On Thu, 13 Oct 2011 14:20:29 +0300, Martin Storsjö <[email protected]> wrote:
Eventually, the old way of passing options by adding
stuff to the URL can be dropped.

This avoids having to tamper with the user-specified URL to
pass options on the transport mode. This also works better
with redirects, since the options don't need to be parsed out
from the URL.
---
 libavformat/rtsp.c    |   28 ++++++++++++++++++++++++++--
 libavformat/rtsp.h    |   12 +++++++++++-
 libavformat/version.h |    5 ++++-
 3 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index e4c4c98..23c7b24 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -59,9 +59,17 @@

 #define OFFSET(x) offsetof(RTSPState, x)
 #define DEC AV_OPT_FLAG_DECODING_PARAM
+#define ENC AV_OPT_FLAG_ENCODING_PARAM
 const AVOption ff_rtsp_options[] = {
     { "initial_pause",  "Don't start playing the stream immediately", 
OFFSET(initial_pause), AV_OPT_TYPE_INT, {0}, 0, 1, DEC },
     FF_RTP_FLAG_OPTS(RTSPState, rtp_muxer_flags),
+    { "rtsp_transport", "RTSP transport protocols", OFFSET(lower_transport_mask), 
AV_OPT_TYPE_FLAGS, {0}, 0, INT_MAX, DEC|ENC, "rtsp_transport" }, \

flags should have min set to INT_MIN, so 'all' keyword works. same for 
rtsp_flags

Otherwise looks fine to me, you can push with the above fixed.

Pushed with this changed, thanks for the reviews!

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to