On 11/11/11 3:59 PM, Sebastien Zwickert wrote:
On Nov 11, 2011, at 10:25 AM, Diego Biurrun wrote:
From: Sebastien Zwickert<[email protected]>
Signed-off-by: Diego Biurrun<[email protected]>
---
This iteration is updated to apply against HEAD, checks a malloc, eliminates
many suspicious casts and does a few more cosmetic changes. It's completely
untested as I have no access to a suitable testing environment. Compilation
and runtime tests highly appreciated. Please use this as base for changes.
The removing of casts in CFDictionaryCreate generates compiler warnings.
The compilation fails cause of the def/undef workaround is necessary.
The compilation fails with gcc-4.2.1 because the emmintrin.h workaround has
been removed.
I do some tests with VLC and I experienced invalid free when opening or closing
the stream. It looks like to be a conflict between ffmpeg-hw and ffmpeg-threads.
Otherwise video playback plays fine through the vda decoder.
Is this something we should fix on libav side now or could be fixed
later? IIRC vaapi and vdpau have similar problems.
Moreover, I put destination image buffer attributes in the vda_context struct in
order to the client is able to choose its preferred output pixel format for
image buffers.
Patch updated in attachment.
The patch looks ok, I'd add back the casts and push it, if somebody is
against it please tell within the next 12 hours =)
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
