On Nov 15, 2011, at 12:50 AM, David Conrad wrote: > On Nov 5, 2011, at 8:05 AM, Sebastien Zwickert wrote: > >> >> On Nov 2, 2011, at 11:45 PM, Diego Biurrun wrote: >>> [...] >>>> --- /dev/null >>>> +++ b/libavcodec/vda.h >>>> @@ -0,0 +1,138 @@ >>>> + >>>> +#ifndef AVCODEC_VDA_H >>>> +#define AVCODEC_VDA_H >>>> + >>>> +#include <stdint.h> >>>> + >>>> +// emmintrin.h is unable to compile with -std=c99 >>>> -Werror=missing-prototypes >>>> +// http://openradar.appspot.com/8026390 >>>> +#undef __GNUC_STDC_INLINE__ >>>> + >>>> +#define Picture QuickdrawPicture >>>> + >>>> +#include <pthread.h> >>>> +#include <VideoDecodeAcceleration/VDADecoder.h> >>>> + >>>> +#include "avcodec.h" >>> [...] >>> Also, can the emmintrin.h workaround be done somewhere else? Where does >>> it get #included from? >> >> It get included from VDADecoder and the compilation fails with gcc 4.2.1 on >> Mac OS 10.6 and 10.7. >> llvm-gcc 4.2.1 which is the default compiler since Xcode 4 and clang compile >> fine without this workaround. > > That reminds me that I never updated that openradar, it was returned as 'not > to be fixed' pretty quickly. > Another workaround is to just disable the offending -Werror for gcc-4.2 for > the file, via > #pragma GCC diagnostic warning "-Wmissing-prototypes"
Thanks for your feedback. This workaround seems to be better that the current undef hack. I'll provide a patch in this way asap. Best regards, Sebastien Zwickert _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
