On 12/02/2011 01:27 PM, Luca Barbato wrote:
> On 02/12/11 18:54, Justin Ruggles wrote:
>> On 12/02/2011 12:40 PM, Luca Barbato wrote:
>>
>>> + for (y = 0; y< b_h; y+=16) {
>>> + s->dsp.put_h264_qpel_pixels_tab[0]
>>> + [dy + (dx>>2)](dst + y * stride,
>>> + src + 3 + (y + 3) * stride, stride);
>>> + s->dsp.put_h264_qpel_pixels_tab[0]
>>> + [dy + (dx>>2)](dst + 16 + y * stride,
>>> + src + 19 + (y + 3) * stride, stride);
>>> }
>>
>>
>> this change and others like it are much less readable than the original.
>
> on my screen it is much more readable. I can revert this chunk and any
> other you deem more readable on full span.
mostly it's just the ones like this with calls from a table of function
pointers. the rest of the patch looks basically ok.
-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
