On Mon, Dec 12, 2011 at 11:36:13PM -0500, Derek Buitenhuis wrote:
> --- /dev/null
> +++ b/libavcodec/v410dec.c
> @@ -0,0 +1,113 @@
> +
> +static av_cold int v410_decode_init(AVCodecContext *avctx)
> +{
> +    avctx->pix_fmt = PIX_FMT_YUV444P10;
> +    avctx->bits_per_raw_sample = 10;

align the '='

> +    
> +    if (avctx->width & 1) {
> +        av_log(avctx, AV_LOG_ERROR, "v410 requires width be even.\n");

to be

> --- /dev/null
> +++ b/libavcodec/v410enc.c
> @@ -0,0 +1,98 @@
> +
> +static av_cold int v410_encode_init(AVCodecContext *avctx)
> +{
> +    if (avctx->width & 1) {
> +        av_log(avctx, AV_LOG_ERROR, "v410 requires width be even.\n");

ditto

There is some code duplication in the init/close functions at least,
but I don't know if it is enough to complain about.

> --- a/libavformat/isom.c
> +++ b/libavformat/isom.c
> @@ -219,6 +219,8 @@ const AVCodecTag codec_movvideo_tags[] = {
>      { CODEC_ID_PRORES, MKTAG('a', 'p', 'c', 'o') }, /* Apple ProRes 422 
> Proxy */
>      { CODEC_ID_PRORES, MKTAG('a', 'p', '4', 'h') }, /* Apple ProRes 4444 */
>  
> +    { CODEC_ID_V410, MKTAG('v', '4', '1', '0') }, /* Quicktime Uncompressed 
> 4:4:4 */
> +
>      { CODEC_ID_NONE, 0 },
>  };

Add this next to V210.

> --- a/libavformat/riff.c
> +++ b/libavformat/riff.c
> @@ -281,6 +281,7 @@ const AVCodecTag ff_codec_bmp_tags[] = {
>      { CODEC_ID_UTVIDEO,      MKTAG('U', 'L', 'Y', '2') },
>      { CODEC_ID_VBLE,         MKTAG('V', 'B', 'L', 'E') },
>      { CODEC_ID_DXTORY,       MKTAG('x', 't', 'o', 'r') },
> +    { CODEC_ID_V410,         MKTAG('v', '4', '1', '0') },
>      { CODEC_ID_NONE,         0 }

ditto

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to