On 13/12/2011 1:50 AM, Kostya Shishkov wrote:
- Dxtory capture format decoder
+- V410 encoder and decoder
Maybe like in doc change below use the full name?
Agreed, and done.
+ u[j] = (val>> 2)& 0x3FF;
please vertically align this line to match the lines below
Done.
+ val = u[j]<< 2;;
nit: 'twould look slightly better as
val |= u[j]<< 2;
(but that's a matter of taste)
one semicolon is redundant though
I've left it as-is for now. If it really bothers you, you're
free to change it before pushing. :)
+
+ return dst - buf;
just calculate and store calculated output size and return it here
Done. Thanks.
+ { CODEC_ID_V410, MKTAG('v', '4', '1', '0') }, /* Quicktime Uncompressed
4:4:4 */
+
wrong place IMO - add it above, right after CODEC_ID_V210 entry
Fixed.
In general - nice work!
Thanks!
- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
