On 13/12/2011 5:17 AM, Diego Biurrun wrote:
+    avctx->pix_fmt = PIX_FMT_YUV444P10;
+    avctx->bits_per_raw_sample = 10;
align the '='

Done.

+
+    if (avctx->width&  1) {
+        av_log(avctx, AV_LOG_ERROR, "v410 requires width be even.\n");
to be

Done.

There is some code duplication in the init/close functions at least,
but I don't know if it is enough to complain about.

I think the amount that is duplicated is trivial, and shoving
it it in its own function is sort of silly. Just my opinion.

--- a/libavformat/isom.c
+++ b/libavformat/isom.c
@@ -219,6 +219,8 @@ const AVCodecTag codec_movvideo_tags[] = {
      { CODEC_ID_PRORES, MKTAG('a', 'p', 'c', 'o') }, /* Apple ProRes 422 Proxy 
*/
      { CODEC_ID_PRORES, MKTAG('a', 'p', '4', 'h') }, /* Apple ProRes 4444 */

+    { CODEC_ID_V410, MKTAG('v', '4', '1', '0') }, /* Quicktime Uncompressed 
4:4:4 */
+
      { CODEC_ID_NONE, 0 },
  };
Add this next to V210.

Done.

- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to