On 02/19/2012 05:41 PM, Martin Storsjö wrote: > On Sun, 19 Feb 2012, Justin Ruggles wrote: > >> --- >> libavcodec/libmp3lame.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c >> index 79384b8..0bf94ae 100644 >> --- a/libavcodec/libmp3lame.c >> +++ b/libavcodec/libmp3lame.c >> @@ -25,7 +25,6 @@ >> */ >> >> #include "libavutil/intreadwrite.h" >> -#include "libavutil/log.h" >> #include "libavutil/opt.h" >> #include "avcodec.h" >> #include "internal.h" >> -- >> 1.7.1 > > Personally, I'm ok with this, but Diego has been advocating explicitly > including all the headers used, even if they're implicitly included by > avcodec.h and similar headers.
for headers, yes, but for .c files? why? -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
