On Sun, Feb 19, 2012 at 05:51:55PM -0500, Justin Ruggles wrote: > On 02/19/2012 05:41 PM, Martin Storsjö wrote: > > On Sun, 19 Feb 2012, Justin Ruggles wrote: > >> > >> --- a/libavcodec/libmp3lame.c > >> +++ b/libavcodec/libmp3lame.c > >> @@ -25,7 +25,6 @@ > >> > >> #include "libavutil/intreadwrite.h" > >> -#include "libavutil/log.h" > >> #include "libavutil/opt.h" > > > > Personally, I'm ok with this, but Diego has been advocating explicitly > > including all the headers used, even if they're implicitly included by > > avcodec.h and similar headers. > > for headers, yes, but for .c files? why?
Mans is the original advocate of the policy that files should explicitly #include all the headers they require. I guess we need to make up our minds about what the proper policy should be. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
