On Mon, 20 Feb 2012, Diego Biurrun wrote:
On Sun, Feb 19, 2012 at 05:51:55PM -0500, Justin Ruggles wrote:
On 02/19/2012 05:41 PM, Martin Storsjö wrote:
On Sun, 19 Feb 2012, Justin Ruggles wrote:
--- a/libavcodec/libmp3lame.c
+++ b/libavcodec/libmp3lame.c
@@ -25,7 +25,6 @@
#include "libavutil/intreadwrite.h"
-#include "libavutil/log.h"
#include "libavutil/opt.h"
Personally, I'm ok with this, but Diego has been advocating explicitly
including all the headers used, even if they're implicitly included by
avcodec.h and similar headers.
for headers, yes, but for .c files? why?
Mans is the original advocate of the policy that files should explicitly
#include all the headers they require. I guess we need to make up our
minds about what the proper policy should be.
I'd prefer not to have to explicitly include every include file included
by avcodec.h/avformat.h/avutil.h, since as Justin pointed out on irc, this
would mean quite a number of files which need to be included in almost
every single c file. Also, with this definition, it's kinda hard to keep
track of what's correct and what's not, compared to the simpler version
("does it compile?") if we allow using implicitly included files.
For system headers, we should of course include all the headers we use,
since things otherwise might break on different systems.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
