On 02/29/2012 10:15 AM, Christophe Gisquet wrote:
Comments below not redundant, but maybe again on the verge of being too early.
2012/2/28 Mashiat Sarker Shakkhar<[email protected]>:
+ int acfilter_prevvalues[2][16];
[...]
+ int mclms_prevvalues[64];
[...]
+ int lms_prevvalues[512];
[...]
+ int channel_residues[2][2048];
[...]
+ int lpc_coefs[2][40];
[...]
+ int channel_coeffs[2][2048];
Those should probably be int32_t, and declared as aligned (the cdlms
ones really need it for dsp). This is not a requirement, it could
probably be folded in a dsp-prepatory later patch.
And another consideration for later: I don't know what>16bits content
requires for those, but may templating be used (e.g. having code and
types having 2 sets of instances, like in H.264)?
Christophe
Yes, and I think optimizing for 16bit files only is ok. I think 99% of
the content will be in that format.
MvH
Benjamin Larsson
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
