----- Original Message -----
> From: Diego Biurrun <[email protected]>
> To: libav development <[email protected]>
> Cc:
> Sent: Wednesday, February 29, 2012 9:05 PM
> Subject: Re: [libav-devel] [PATCH] Windows Media Audio Lossless decoder
>
> On Wed, Feb 29, 2012 at 06:38:41AM -0800, Mashiat Sarker Shakkhar wrote:
>> ----- Original Message -----
>>
>> > From: Diego Biurrun <[email protected]>
>> > To: libav development <[email protected]>
>> > Cc:
>> > Sent: Wednesday, February 29, 2012 6:44 PM
>> > Subject: Re: [libav-devel] [PATCH] Windows Media Audio Lossless
> decoder
>> >
>> > Please get another mailer, this Yahoo shit is unbearable.
>>
>> I can get another mailer, but you will have to explain what exactly is
>> wrong with Yahoo. "this Yahoo shit is unbearable" doesn't
> communicate
>> anything to me. For the time being, I'll stick to yahoo.
>
> This Outlook-style abomination your mailer added above my quote for
> starters. It also keeps mangling lines, etc..
>
> It's just more a kid's toy than a professional email program...
Not an argument, so I'll ignore it. Let me put it this way: it served
my purpose so far, and I will switch to some other service when I'll
feel the need.
>
>> >> [...]
>> >> >> + } else {
>> >> >> +/*
>> >> >> + while (get_bits_count(gb) <
> s->num_saved_bits
>> > &&
>> >> > get_bits1(gb) == 0) {
>> >> >> + av_dlog(s->avctx, AV_LOG_DEBUG,
>> > "skip1\n");
>> >> >> + }
>> >> >> +*/
>> >> >> + }
>> >> >
>> >> > ?
>> >> >
>> >> > Also, indentation is off.
>> >>
>> >> That's something the spec says we should do, but Andreas
> decided
>> >> to disable it for some reason that I don't know /
> understand. I'd
>> >> like to keep that code around in some form, may be someday
> we will
>> >> come across a sample which uses that feature.
>> >
>> > Please no commented-out cruft, much less badly formatted and
> completely
>> > without explanation.
>>
>> OK. Let me check if I can find any sample the above code breaks. Then
>> I'd feel comfortable about removing it. Otherwise, I'm going to
> enable
>> it in the next update.
>
> Samples that commented-out code printing debug messages breaks?
> I'd sure be curious about those ;)
"commented-out code printing debug messages"? I believe you know what
get_bits1() do, right? Are we talking about the same code here? I think
there is a communication gap, obviously by "Let me check if I can find
any sample the above code breaks" I meant that I'll enable that code,
and check if it breaks samples. I have already explained why I am being
careful with this - the spec seems to require it.
Anyways, now I have tested it and it does break decoding, so that code
will be removed in the next updated of the patch.
>
> Diego
> _______________________________________________
> libav-devel mailing list
> [email protected]
> https://lists.libav.org/mailman/listinfo/libav-devel
>
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
