Hi, On Fri, May 11, 2012 at 9:12 AM, Christophe Gisquet <[email protected]> wrote: > Hi and thanks, > > 2012/5/11 Ronald S. Bultje <[email protected]>: >> The problem is the pshufw emitted by SPLATW (see >> libavutil/x86/x86util.asm). It should use punpcklwd+punpckldq on mmx. > > Then I guess the additional patch here is needed. Maybe fixing it > globally in x86util.asm is better, but I only need a specific > behaviour of SPLATW here, and the whole behaviour can't be emulated in > MMX. > > Both patches once applied result in the same MD5 values, but maybe > checking on an actual MMX host is better.
I agree a cpuflags-based SPLATW implementation would be wonderful. Do you have time to go through all current users of SPLATW to ensure we don't break anything (i.e. make it use mmx code where mmx2 was intended because it doesn't use cpuflags yet)? If not, I can do that over the weekend, hopefully. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
