> +%macro CONV_S16_TO_S16P_6CH 0
> +cglobal conv_s16_to_s16p_6ch, 2,8,5, dst, src, dst1, dst2, dst3, dst4, dst5, 
> len
> +%if ARCH_X86_64
> +    mov      lend, r2d
> +%else
> +    %define lend dword r2m
> +%endif
> +    mov     dst1q, [dstq+  gprsize]
> +    mov     dst2q, [dstq+2*gprsize]
> +    mov     dst3q, [dstq+3*gprsize]
> +    mov     dst4q, [dstq+4*gprsize]
> +    mov     dst5q, [dstq+5*gprsize]
> +    mov      dstq, [dstq          ]
> +    sub     dst1q, dstq
> +    sub     dst2q, dstq
> +    sub     dst3q, dstq
> +    sub     dst4q, dstq
> +    sub     dst5q, dstq
> +    ALIGN 16
> +.loop:
> +    mova       m0, [srcq         ]  ; m0 =  0,  1,  2,  3,  4,  5,  6,  7
> +    mova       m1, [srcq+  mmsize]  ; m1 =  8,  9, 10, 11, 12, 13, 14, 15
> +    mova       m2, [srcq+2*mmsize]  ; m2 = 16, 17, 18, 19, 20, 21, 22, 23
> +    movhlps    m3, m1
> +    movlhps    m3, m2               ; m3 = 12, 13, 14, 15, 16, 17, 18, 19
> +    movlhps    m1, m1
> +    movhlps    m1, m0               ; m1 =  4,  5,  6,  7,  8,  9, 10, 11

Using more loads (and fewer shuffles) might be better here, e.g:

mova  m0, [srcq         ]
mova  m2, [srcq+2*mmsize]
movq  m3, [srcq + mmsize + mmsize/2]
movlhps m3, m2
movq m1, [srcq+  mmsize]
movhlps m1, m0

One more load, two less shuffles, the load is probably free.

> +    psrldq     m1, 4                ; m1 =  6,  7,  8,  9, 10, 11,  x,  x
> +    psrldq     m2, 4                ; m2 = 18, 19, 20, 21, 22, 23,  x,  x
> +    punpcklwd  m4, m0, m1           ; m4 =  0,  6,  1,  7,  2,  8,  3,  9
> +    punpckhwd  m0, m1               ; m0 =  4, 10,  5, 11,  x,  x,  x,  x
> +    punpcklwd  m1, m3, m2           ; m1 = 12, 18, 13, 19, 14, 20, 15, 21
> +    punpckhwd  m3, m2               ; m3 = 16, 22, 17, 23,  x,  x,  x,  x
> +    punpckldq  m2, m4, m1           ; m2 =  0,  6, 12, 18,  1,  7, 13, 19
> +    punpckhdq  m4, m1               ; m4 =  2,  8, 14, 20,  3,  9, 15, 21
> +    punpckldq  m0, m3               ; m0 =  4, 10, 16, 22,  5, 11, 17, 23
> +    movlpd  [dstq      ], m2
> +    movhpd  [dstq+dst1q], m2
> +    movlpd  [dstq+dst2q], m4
> +    movhpd  [dstq+dst3q], m4
> +    movlpd  [dstq+dst4q], m0
> +    movhpd  [dstq+dst5q], m0

movhps and movq please.

> +    add      srcq, mmsize*3
> +    add      dstq, mmsize/2
> +    sub      lend, mmsize/4
> +    jg .loop
> +    REP_RET

Otherwise looks okay.

Jason
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to