On 10/01/2012 12:07 AM, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Sep 30, 2012 at 1:00 PM, Peter B. <[email protected]> wrote:
>> +    PIX_FMT_0RGB=0x123+4,      ///< packed RGB 8:8:8, 32bpp, 0RGB0RGB...
>> +    PIX_FMT_RGB0,      ///< packed RGB 8:8:8, 32bpp, RGB0RGB0...
>> +    PIX_FMT_0BGR,      ///< packed BGR 8:8:8, 32bpp, 0BGR0BGR...
>> +    PIX_FMT_BGR0,      ///< packed BGR 8:8:8, 32bpp, BGR0BGR0...
> 
> These look wrong. Also, the 0x123+4 value should go, maybe that's a 
> ffmpeg'ism?

+1

>> +    PIX_FMT_YUVA444P,  ///< planar YUV 4:4:4 32bpp, (1 Cr & Cb sample
>> per 1x1 Y & A samples)
>> +    PIX_FMT_YUVA422P,  ///< planar YUV 4:2:2 24bpp, (1 Cr & Cb sample
>> per 2x1 Y & A samples)

Might be useful, even if I'm unsure about uses

>> +    PIX_FMT_YUV420P12BE, ///< planar YUV 4:2:0,18bpp, (1 Cr & Cb sample
>> per 2x2 Y samples), big-endian
>> +    PIX_FMT_YUV420P12LE, ///< planar YUV 4:2:0,18bpp, (1 Cr & Cb sample
>> per 2x2 Y samples), little-endian
>> +    PIX_FMT_YUV420P14BE, ///< planar YUV 4:2:0,21bpp, (1 Cr & Cb sample
>> per 2x2 Y samples), big-endian
>> +    PIX_FMT_YUV420P14LE, ///< planar YUV 4:2:0,21bpp, (1 Cr & Cb sample
>> per 2x2 Y samples), little-endian
>> +    PIX_FMT_YUV422P12BE, ///< planar YUV 4:2:2,24bpp, (1 Cr & Cb sample
>> per 2x1 Y samples), big-endian
>> +    PIX_FMT_YUV422P12LE, ///< planar YUV 4:2:2,24bpp, (1 Cr & Cb sample
>> per 2x1 Y samples), little-endian
>> +    PIX_FMT_YUV422P14BE, ///< planar YUV 4:2:2,28bpp, (1 Cr & Cb sample
>> per 2x1 Y samples), big-endian
>> +    PIX_FMT_YUV422P14LE, ///< planar YUV 4:2:2,28bpp, (1 Cr & Cb sample
>> per 2x1 Y samples), little-endian
>> +    PIX_FMT_YUV444P12BE, ///< planar YUV 4:4:4,36bpp, (1 Cr & Cb sample
>> per 1x1 Y samples), big-endian
>> +    PIX_FMT_YUV444P12LE, ///< planar YUV 4:4:4,36bpp, (1 Cr & Cb sample
>> per 1x1 Y samples), little-endian
>> +    PIX_FMT_YUV444P14BE, ///< planar YUV 4:4:4,42bpp, (1 Cr & Cb sample
>> per 1x1 Y samples), big-endian
>> +    PIX_FMT_YUV444P14LE, ///< planar YUV 4:4:4,42bpp, (1 Cr & Cb sample
>> per 1x1 Y samples), little-endian
>> +    PIX_FMT_GBRP12BE,    ///< planar GBR 4:4:4 36bpp, big endian
>> +    PIX_FMT_GBRP12LE,    ///< planar GBR 4:4:4 36bpp, little endian
>> +    PIX_FMT_GBRP14BE,    ///< planar GBR 4:4:4 42bpp, big endian
>> +    PIX_FMT_GBRP14LE,    ///< planar GBR 4:4:4 42bpp, little endian
> 
> These look OK.

Are the 14bit used?

> Aren't their entries in the relevant table in libavutil/pixdesc.c missing?

Yes that part is missing ^^;

lu

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to