On Sat, Aug 03, 2013 at 08:25:12PM -0300, Diogo Franco (Kovensky) wrote: > --- a/cmdutils.c > +++ b/cmdutils.c > @@ -182,7 +182,7 @@ static const OptionDef *find_option(const OptionDef *po, > const char *name) > > -#if HAVE_COMMANDLINETOARGVW > +#if HAVE_COMMANDLINETOARGVW && !defined(__CYGWIN__) > #include <windows.h> > #include <shellapi.h>
I don't like this at all. We should not be adding system ifdefs to places that are cleanly covered by configure checks. > --- a/libavformat/os_support.c > +++ b/libavformat/os_support.c > @@ -27,7 +27,7 @@ > > -#if defined(_WIN32) && !defined(__MINGW32CE__) > +#if defined(_WIN32) && !defined(__MINGW32CE__) && !defined(__CYGWIN__) > #undef open > #undef lseek > #undef stat I'm sure there's a way to test for this instead. > --- a/libavformat/os_support.h > +++ b/libavformat/os_support.h > @@ -31,14 +31,14 @@ > -#ifdef _WIN32 > +#if defined(_WIN32) && !defined(__CYGWIN__) > #if HAVE_DIRECT_H > #include <direct.h> > #elif HAVE_IO_H This is for mkdir(), not some charset workarounds. It should not be that hard to detect two-argument mkdir() in configure. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
