On Sun, 4 Aug 2013, Diego Biurrun wrote:
On Sat, Aug 03, 2013 at 08:25:12PM -0300, Diogo Franco (Kovensky) wrote:
--- a/cmdutils.c
+++ b/cmdutils.c
@@ -182,7 +182,7 @@ static const OptionDef *find_option(const OptionDef *po,
const char *name)
-#if HAVE_COMMANDLINETOARGVW
+#if HAVE_COMMANDLINETOARGVW && !defined(__CYGWIN__)
#include <windows.h>
#include <shellapi.h>
I don't like this at all. We should not be adding system ifdefs to
places that are cleanly covered by configure checks.
Unfortunately, the situation is tricky to handle purely with configure
checks. Both plain win32 and cygwin give you a normal main(int, char**),
but on win32, the args will be in the local native codepage (which doesn't
cover the full unicode range but only a specific subset), while on cygwin
it apparently already is converted to utf8. On cygwin, all the original
windows functions still are available, so the test says the function
exists and is usable.
Diogo, does this part actually fix an issue itself, or is it just to avoid
needless workarounds? Does it harm anything if this is kept as is, to
simplify the conditions? (That is, since cygwin does support the win32
api, the function is available and we'd hope that using it should work as
intended on cygwin as well.)
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
