On Sun, Feb 23, 2014 at 11:52:54AM +0100, Janne Grunau wrote:
> On 2013-11-02 17:21:49 +0100, Diego Biurrun wrote:
> > --- a/configure
> > +++ b/configure
> > +check_func_headers malloc.h _aligned_malloc     && enable aligned_malloc
> >  check_func  fcntl
> >  check_func  fork
> >  check_func_headers stdlib.h getenv
> >  check_func  gethrtime
> >  check_func  getopt
> >  check_func  getrusage
> > -check_struct "sys/time.h sys/resource.h" "struct rusage" ru_maxrss
> 
> no, not everything is or should be alphabetically sorted
> 
> >  check_func  gettimeofday
> >  check_func  inet_aton $network_extralibs
> >  check_func  isatty
> > @@ -3693,24 +3696,19 @@ check_func  ${malloc_prefix}memalign            && 
> > enable memalign
> >  check_func  mkstemp
> >  check_func  mmap
> >  check_func  mprotect
> > +# Solaris has nanosleep in -lrt, OpenSolaris no longer needs that
> > +check_func  nanosleep || { check_func nanosleep -lrt && add_extralibs 
> > -lrt; }
> >  check_func  ${malloc_prefix}posix_memalign      && enable posix_memalign
> > -check_func_headers malloc.h _aligned_malloc     && enable aligned_malloc
> 
> ah, I see now what you're sorting but can we please keep this logical
> grouping too
> 
> > @@ -3739,6 +3737,12 @@ check_header VideoDecodeAcceleration/VDADecoder.h
> >  check_header windows.h
> >  check_header X11/extensions/XvMClib.h
> >  
> > +check_lib2 "windows.h shellapi.h" CommandLineToArgvW -lshell32
> > +check_lib2 "windows.h wincrypt.h" CryptGenRandom -ladvapi32
> > +check_lib2 "windows.h psapi.h" GetProcessMemoryInfo -lpsapi
> 
> probably ok if tested that the other windows check_ld type checks do not
> depend on any of this libs being added before.

I'll resend this shortly split and rebased, for ease of review.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to