On 2014-03-06 14:55:06 +0100, Diego Biurrun wrote: > Group checks into logical groups and sort alphabetically within those groups > unless checks have close coupling. Keep closely coupled checks together. > --- > configure | 49 +++++++++++++++++++++++++++---------------------- > 1 file changed, 27 insertions(+), 22 deletions(-) > > diff --git a/configure b/configure > index 91d5ae3..d10bd66 100755 > --- a/configure > +++ b/configure > @@ -3805,19 +3805,19 @@ elif check_func dlopen -ldl; then > fi > > if ! disabled network; then > - check_type "sys/types.h sys/socket.h" socklen_t > + check_func getaddrinfo $network_extralibs > + check_func getservbyport $network_extralibs > + check_func inet_aton $network_extralibs > + check_struct "sys/types.h sys/socket.h" "struct sockaddr" sa_len
having this below 'check_type "sys/types.h sys/socket.h" socklen_t' would improve sorting > check_type netdb.h "struct addrinfo" > check_type netinet/in.h "struct group_source_req" -D_BSD_SOURCE > check_type netinet/in.h "struct ip_mreq_source" -D_BSD_SOURCE > check_type netinet/in.h "struct ipv6_mreq" -D_DARWIN_C_SOURCE > - check_type netinet/in.h "struct sockaddr_in6" > check_type poll.h "struct pollfd" this looks misordered > - check_type "sys/types.h sys/socket.h" "struct sockaddr_storage" > - check_struct "sys/types.h sys/socket.h" "struct sockaddr" sa_len > + check_type netinet/in.h "struct sockaddr_in6" > check_type netinet/sctp.h "struct sctp_event_subscribe" > - check_func getaddrinfo $network_extralibs > - check_func getservbyport $network_extralibs > - check_func inet_aton $network_extralibs > + check_type "sys/types.h sys/socket.h" "struct sockaddr_storage" > + check_type "sys/types.h sys/socket.h" socklen_t > # Prefer arpa/inet.h over winsock2 > if check_header arpa/inet.h ; then > check_func closesocket the rest looks ok if tested on windows Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
