On Tue, Mar 11, 2014 at 12:21:37AM +0100, Janne Grunau wrote:
> On 2014-03-11 00:08:20 +0100, Diego Biurrun wrote:
> > On Mon, Mar 10, 2014 at 04:20:52PM +0100, Janne Grunau wrote:
> > > On 2014-03-06 14:55:06 +0100, Diego Biurrun wrote:
> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -3805,19 +3805,19 @@ elif check_func dlopen -ldl; then
> > > >      check_type netdb.h "struct addrinfo"
> > > >      check_type netinet/in.h "struct group_source_req" -D_BSD_SOURCE
> > > >      check_type netinet/in.h "struct ip_mreq_source" -D_BSD_SOURCE
> > > >      check_type netinet/in.h "struct ipv6_mreq" -D_DARWIN_C_SOURCE
> > > > -    check_type netinet/in.h "struct sockaddr_in6"
> > > >      check_type poll.h "struct pollfd"
> > > 
> > > this looks misordered
> > 
> > ?
> 
> context missing, the next 3 lines in the patch are:
> 
> | -    check_type "sys/types.h sys/socket.h" "struct sockaddr_storage"
> | -    check_struct "sys/types.h sys/socket.h" "struct sockaddr" sa_len
> | +    check_type netinet/in.h "struct sockaddr_in6"
> 
> resulting in:
> 
> check_type netinet/in.h "struct ipv6_mreq" -D_DARWIN_C_SOURCE
> check_type poll.h "struct pollfd"
> check_type netinet/in.h "struct sockaddr_in6"

Yes, I sorted by type name, not by header name.  That seemed more sensible
to me, but I don't particularly care as long as we clean up the current
chaos.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to