Hi,

in commit 3a19405d574a467c68b48e4b824c76617fd59de0 the AVProbeData.mime_type and AVInputFormat.mime_type fields were added, but they have different types: AVProbeData.mime_type is uint8_t*, while AVInputFormat.mime_type is const char*. The latter seems to be more correct, since both are used as arguments for av_match_name, which takes const char*.

Attached patch changes AVProbeData.mime_type to const char* to make this consistent.

Best regards,
Andreas
>From 5d526ed62d6583d6ff6a6b86c7cf9d48ac0de3c3 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun <[email protected]>
Date: Sun, 14 Sep 2014 00:37:31 +0200
Subject: [PATCH] lavf/avformat.h: use const char* instead of uint8_t* for
 AVProbeData.mime_type

This makes the field consistent with AVInputFormat.mime_type and the argument type of av_match_name.

Signed-off-by: Andreas Cadhalpun <[email protected]>
---
 libavformat/avformat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 923b282..f28186f 100644
--- a/libavformat/avformat.h
+++ b/libavformat/avformat.h
@@ -396,7 +396,7 @@ typedef struct AVProbeData {
     const char *filename;
     unsigned char *buf; /**< Buffer must have AVPROBE_PADDING_SIZE of extra allocated bytes filled with zero. */
     int buf_size;       /**< Size of buf except extra allocated bytes */
-    uint8_t *mime_type; /**< mime_type, when known. */
+    const char *mime_type; /**< mime_type, when known. */
 } AVProbeData;
 
 #define AVPROBE_SCORE_EXTENSION  50 ///< score for file extension
-- 
2.1.0

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to