On 14/09/14 00:45, Andreas Cadhalpun wrote: > On 14.09.2014 00:43, Luca Barbato wrote: >> On 14/09/14 00:41, Andreas Cadhalpun wrote: >>> Hi, >>> >>> in commit 3a19405d574a467c68b48e4b824c76617fd59de0 the >>> AVProbeData.mime_type and AVInputFormat.mime_type fields were added, but >>> they have different types: AVProbeData.mime_type is uint8_t*, while >>> AVInputFormat.mime_type is const char*. The latter seems to be more >>> correct, since both are used as arguments for av_match_name, which takes >>> const char*. >>> >>> Attached patch changes AVProbeData.mime_type to const char* to make this >>> consistent. >> >> It isn't enough since just doing that would generate a warning, I'm not >> against the change all in all. > > What else needs to be changed?
check the generated warning, the whole stuff generated by getting the data from avoption and that means that the data is recovered as uint8_t *. (you should notice since the warning generated is quite wordy). lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
