On Mon, Sep 29, 2014 at 11:54 AM, Vittorio Giovara
<[email protected]> wrote:
> On Sun, Sep 14, 2014 at 8:13 PM, Reinhard Tartler <[email protected]> wrote:
>> On Sun, Sep 14, 2014 at 3:00 PM, Luca Barbato <[email protected]> wrote:
>>> On 14/09/14 20:57, Reinhard Tartler wrote:
>>>> The patch looks fine to me for backporting to release/11
>>>
>>> Are we ok in considering it an API clarification (so it gets in as-is)
>>> instead of an API change (with the warning period and so on).
>>>
>>> uint8_t* and char* for all we are concerned are the same.
>>
>> Yes, that is my understanding.
>
> Queueing for HEAD and release/11 with minor cosmetic changes.
And unqueued, the following section looks shady
if (pb->av_class)
- av_opt_get(pb, "mime_type", AV_OPT_SEARCH_CHILDREN, &pd.mime_type);
+ av_opt_get(pb, "mime_type", AV_OPT_SEARCH_CHILDREN, &mime_type_opt);
+ pd.mime_type = (const char *)mime_type_opt;
+ mime_type_opt = NULL;
There is either a missing {} pair or indenting there is too misleading.
Waiting for a few more comments on it or for the author to chime in.
--
Vittorio
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
