On Sun, Sep 28, 2014 at 7:03 PM, Luca Barbato <[email protected]> wrote: > On 28/09/14 17:25, Reinhard Tartler wrote: >> >> From: Michael Niedermayer <[email protected]> >> >> If we can make use of O_CLOEXEC, we don't need the fcntl() call. On >> systems that don't support O_CLOEXEC, try to reconfigure the file >> descriptor using the fcntl() API, but ignore failures. > > > I'd drop this patch and mark the report as "on purpose - ignore". > > (again, let's try to take the report for what they are and try to make good > use of it instead of blindly shut them off no matter what).
for CID-less folks, the report is on line 88-89, and it's about "check_return: Calling fcntl(fd, 2, 1) without checking return value. This library function may fail and return an error code." We do ignore the return value on a function that is allowed to fail, not sure of the gravity of it. I'd not mind returning it properly but not sure if it's worthwhile. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
