Le 2014-09-28 23:41, Vittorio Giovara a écrit :
for CID-less folks, the report is on line 88-89, and it's about
"check_return: Calling fcntl(fd, 2, 1) without checking return value.
This library function may fail and return an error code."

There are absolutely no sane circumstances in which this fcntl(F_SETFD) would fail and the least insane thing to do is ignore the error. Yes, fcntl() can fail, but on some other F_* operations.

Besides, you are already screwed if you need to call fcntl() to begin with. It means the system lacks O_CLOEXEC and thus file descriptors allocation is not thread-safe fork-safe. If fcntl() were to fail too, then you merely loose non-threaded fork safety.

--
Rémi Denis-Courmont
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to