On 07/12/14 11:02, Anton Khirnov wrote:
Quoting Luca Barbato (2014-12-06 12:34:56)
---
  libavformat/mp3dec.c | 96 ++++++++++++++++++++++++++++++----------------------
  1 file changed, 55 insertions(+), 41 deletions(-)


Stab. The formatting in the majority of the file is perfectly fine.
Yes, the missing spaces in read_probe() can be fixed, but do you really have to
do random cosmetics on the whole file each time you touch something. It just
obscures history for no good reason whatsoever.


Counterstab: I need to *read* the code in order to fix it. Randomly indented code is harder to read.


_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to