Quoting Luca Barbato (2014-12-07 17:53:57) > On 07/12/14 16:34, Anton Khirnov wrote: > > Are you saying that code that does not have perfect vertical alignment > > everywhere according to your personal rules is unreadable for you? Then > > I have to wonder how can you read anything anywhere. > > I guess this discussion is derailing, I couldn't care less about > vertical alignment, I hate to have overly long lines and random spacing > though. >
Vertical alignment is not the point here. My objections apply equally to other trivial cosmetics. A single missing space in if( does not make the code unreadable. > > Then I have no idea what your original comment was about. > > I noticed. > > > If those patches do not exist yet, then there is nothing to conflict. > > As said so far I just have the 3 patches I wrote while returning home > and I already dropped the wider cosmetics given the warm welcome the > other received and kept just the functional changes. > > > And I really hope you do not seriously intend to add cosmetics to every > > single security fix. > > No, but I might have cleanups here and there since, as I said, I like to > _read_ before fixing stuff and the simplest way for me is just to gq the > whole file. Simplest for you maybe. But as I said previously, it'd be a disaster if everyone did it. To summarise my views on cosmetics: - full file reformattings are acceptable ONLY if the file looks like a relic from 2003 (the number of such files in the codebase these days is very small) - local (function scope and smaller) reformattings are ok if the specific piece of code does not conform to the accepted rules or along with code changes - other cosmetics should be avoided -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
