Quoting Luca Barbato (2014-12-07 11:13:03) > On 07/12/14 11:02, Anton Khirnov wrote: > > Quoting Luca Barbato (2014-12-06 12:34:56) > >> --- > >> libavformat/mp3dec.c | 96 > >> ++++++++++++++++++++++++++++++---------------------- > >> 1 file changed, 55 insertions(+), 41 deletions(-) > >> > > > > Stab. The formatting in the majority of the file is perfectly fine. > > Yes, the missing spaces in read_probe() can be fixed, but do you really > > have to > > do random cosmetics on the whole file each time you touch something. It just > > obscures history for no good reason whatsoever. > > > > Counterstab: I need to *read* the code in order to fix it. Randomly > indented code is harder to read. >
1) while vertical alignment does in many cases improve readability, its absence is not so horrible as to make the code unreadable 2) the second patch in the series does not in any way require reading the parts you are reindenting As we already discussed several times before, overzealous cosmetics is BAD. It adds more unnecessary cruft to the history, is hard to review properly and carries a risk of introducing hard to find bugs, since few (or no) people actually check that the generated code is the same before and after. What's more, it's not a convergent procedure, since different people have different views on what is proper indentation for vertical alignment. Of course fixing horribly formatted unreadable files from 2003 is good and just, but that is certainly not the case here. So please, no unnecessary cosmetics unless you actually touch the code in question. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
