On Tue, May 12, 2015 at 9:10 AM, Diego Biurrun <[email protected]> wrote: >> Because some parts were ok'd, some parts were rejected while they were >> actually ok, some parts needed to be redone. It was too confusing for >> me, I preferred a clean slate. > > The lesson here seems to be that the patch is too big and should be split.
I will let the preaching tone slide one last time. > Then the uncontroversial OKed bits wouldn't clutter up further reviews. To be honest it's very hard to understand where is the limit in keeping the patches together and in splitting them, since every time I did one of either you told me I could have done the opposite. Now, more on the constructive part, I don't see how they clutter up further reviews since they were completely unchanged. In my opinion it makes sense to keep this patch in a single commit since it operates at global scope on lavc and it's not doing much more than adding if (!something) return AVERROR(ENOMEM) in a few sweetspots. > Please split the patch. As I've stated, I am not going to do it for the aforementioned reasons. No objections in doing that yourself if you feel like it's important. -- Vittorio _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
