On 5/12/2015 3:56 PM, Diego Biurrun wrote: > I have no idea what you are trying to tell me. The reviewer should > fix what the patch submitter failed to fix for n rounds of review?
I'll break it down. Please: 1) Be less condescending. 2) Be consistent between reviews in what you request. 3) Less of a stickler. You don't to absolutely demand someone sends Yet Another Revision of a patch set if only minor fixes are needed. It's a waste of everybody's time, and only annoys the author. 4) Consider what's better to actually go into the tree, not what's easier to review. 5) Do not insist authors do stuff like splitting patches or fixing some nits, if in reality, it makes no difference, and is only your preference. Do it yourself if it bothers you that much. - Derek _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
